Hjælp med at lave Lottotræknings program i c++

(rand() % 36) + 1;

Tak for hjælpen,men jeg kan ikke se hvorhen den skal ind i koden,
Den stadvigt trækker den samme tal igen og igen.

F.eks:

#include <cstdlib>
#include <ctime>
#include <iostream>
using namespace std;

int main()
{
   srand((unsigned)time(0));
   int random_integer;
   for(int index = 0; index < 7; index++)
   {
      random_integer = 1 + rand()%36;
      cout << random_integer << endl;
   }

   cin.get();
}

Det skulle gerne give dig 7 tilfældige tal, der er forskellige hver gang du kører programmet.

Det næste problem er at du risikerer at to eller flere af disse tal er ens, det går ikke med lottotal...

Det skulle gerne give dig 7 tilfældige tal, der er forskellige hver gang du kører programmet.

Det næste problem er at du risikerer at to eller flere af disse tal er ens, det går ikke med lottotal...

Well...hvis du kører programmet to gange inden for samme sekund, så får du faktisk den samme række.

F.eks:

Kode 

#include <cstdlib>
#include <ctime>
#include <iostream>
using namespace std;

int main()
{
   srand((unsigned)time(0));
   int random_integer;
   for(int index = 0; index < 7; index++)
   {
      random_integer = 1 + rand()%36;
      cout << random_integer << endl;
   }

   cin.get();
}

Det skulle gerne give dig 7 tilfældige tal, der er forskellige hver gang du kører programmet.

Det næste problem er at du risikerer at to eller flere af disse tal er ens, det går ikke med lottotal...

Tak for det Bertel

jeg havde fået det til at virke på den måde her

#include "stdafx.h"

#include <cstdlib>
#include <ctime>
#include <iostream>
using namespace std;

int main()
{
srand((unsigned)time(0));

int random_integer;
for(int index=0; index < 1; index++){
random_integer = (rand() % 36) + 1;
cout << random_integer << endl;
}

cin.get();
return 0;
}

det er samme, bare anden opsætning,
Tak, Nu må jeg bare gå videre med det her.

Hej igen

Jeg får to fejler "Warning" når jeg prøver at gøre "Build solution"

Den her:

(114) : warning C4311: 'type cast' : pointer truncation from 'int *__w64 ' to 'unsigned int'

og
Den
(93) : error C4716: 'Lynlotto' : must return a value

Kan i se fejlen,
Her følger koden med:

Tak for hjælpen
Mvh
Finns

#include "stdafx.h"


// MMT.cpp : Defines the entry point for the console application.
//

#include "stdafx.h"

#include <iostream>
#include <string>
#include <list>
#include <cstdlib>
#include <algorithm> //find()
#include <sstream>  //ostringstream
#include <iomanip> //setfill() setw();

using namespace std;
const int NUMBER_COUNT = 7;
const int NUMBER_MAX = 36;
const int NUMBER_MIN = 1;
const int ROWS_COUNT = 10;


//*****************************************************************************
//    Function that returns random number between NUMBER_MIN and NUMBER_MAX
//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
int Bold()
{
    return (rand() % (NUMBER_MAX - NUMBER_MIN + 1) + NUMBER_MIN);
}

//*****************************************************************************
// Returns random number between NUMBER_MIN and NUMBER_MAX
// Will always return a different random number until this function is call
// whith new_draw=true.
//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
int Kugle(bool new_draw = false)
{
    static list<int> drawn_lst; //list to keep values that have been draw.
    if (new_draw) // Clean and return.
    {
        drawn_lst.clear(); //New deal, clears the list
    }
    else if (drawn_lst.size() >= NUMBER_MAX)
    {
        cout << "*** No more balls - clear list ***" << endl;
        drawn_lst.clear();
    }
    else
    {
        int ball = 0;
        do
        {
            ball = Bold();
        }
        while (drawn_lst.end() != find(drawn_lst.begin(), drawn_lst.end(), ball));
        drawn_lst.push_back(ball);
    }
    return drawn_lst.back();
}


//*****************************************************************************
// Inserts random numbers in the list lst.
// Count of random numbers are NUMBER_COUNT.
//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
void Saturday(list<int> &lst)
{
    for (int i = 0;NUMBER_COUNT > i;i++)
    {
        lst.push_back(Kugle());
    }
}


//*****************************************************************************
// Inserts random numbers in list and then insert list in list of list(row_lst).
// cont of random numbers are NUMBER_COUNT
// cont of list in list are ROWS_COUNT
//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
int Lynlotto(list< list<int> > &row_lst)
{
    for(int i=0; ROWS_COUNT>i;i++)
    {
        list<int> lst;
        Kugle(true);  //Clears the already drawn list of numbers.
        Saturday(lst); //add random numbers to lst
        row_lst.push_back(lst);
    }
}

//*****************************************************************************
//   converts list of int to string e.g. [2] [23] [8] ... etc.
//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
std::string listToString(list<int> &lst)
{
    std::ostringstream o;
    list<int>::iterator it;
    for ( it = lst.begin() ; it != lst.end(); it++ )
    {
        o << " [" << setw(2) << setfill(' ') << *it << "]";
    }
    return o.str();
}

//*****************************************************************************
//   The main funtion
//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
int main(int c, char **a)
{
    srand((unsigned)&c);
    list< list<int> > lynlotto_lst;  //This is a list of list of integers
    list<int> saturday_lst;  //this is a list of integers
    int bonus_number;  //to keep the bonus number.

    Saturday(saturday_lst); //add random numbers to lst
    bonus_number = Kugle(); //Draw the bonus number
    Kugle(true); //Clear drawn nubmer list.
    Lynlotto(lynlotto_lst); //add random numbers to lst x 10

    cout << endl << "The lotto numbers are:" << endl << "   " << listToString(saturday_lst) << " bonus[" << Kugle() << "]" << endl;

    int ln_num = 0;
    list< list<int> >::iterator it_lyn_rows;
     cout << "The selected numbers are:" << endl;
     for ( it_lyn_rows = lynlotto_lst.begin() ; it_lyn_rows != lynlotto_lst.end(); it_lyn_rows++ )
    {
        ln_num++;
        cout <<  setw(2) << setfill(' ')<< ln_num << ":" <<listToString(*it_lyn_rows) << endl;
    }



    cout << endl << endl;
    return 0;
}

int Lynlotto(list< list<int> > &row_lst)
{
    for(int i=0; ROWS_COUNT>i;i++)
    {
        list<int> lst;
        Kugle(true);  //Clears the already drawn list of numbers.
        Saturday(lst); //add random numbers to lst
        row_lst.push_back(lst);
    }
}

Denne funktion returnerer ikke noget, og det lader det til, at den heller ikke skal, så returtypen skal være void.

I Kugle() funktionen:

    else if (drawn_lst.size() >= NUMBER_MAX)

...sammenligner du returværdien af size() metoden (som er en unsigned integer) med en signed integer. Du kan typecaste værdien eksplicit:

    else if (drawn_lst.size() >= (unsigned int)NUMBER_MAX)

...eller du kan bruge defines istedet:

#define NUMBER_COUNT 7
#define NUMBER_MAX 36
#define NUMBER_MIN 1
#define ROWS_COUNT 10

Tak for det.. nu fik jeg det "built" og compile med de her resultater:

1>------ Build started: Project: Full LynLotto opgave, Configuration: Debug Win32 ------
1>Compiling...
1>Skipping... (no relevant changes detected)
1>Full LynLotto opgave.cpp
1>Build log was saved at "file://c:\Finnur\Elektrikingenior IOT\Reeksam i E-DTP\Full LynLotto opgave\Full LynLotto opgave\Debug\BuildLog.htm"
1>Full LynLotto opgave - 0 error(s), 0 warning(s)
========== Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========

Har lavet de ændringer som du snakkeder om
også i int main, har jeg gjort det her
//srand((unsigned)&c);



Men så hvis jeg vil så debug, så kommer bare en
kæmpe fejl.

Debug Assertion Failed!

Program:...
File:c:\program files\microsoft visual studio8\vc\include\list
Line:262

Expression: list iterator not decrementable

For information on how your program can cause an assertion failure, see the visualC++ doocumentation on asserts.

(press retry to debug the application)

"Abort" "Retry" "Ignore"



Hele Koden:

#include "stdafx.h"

#include <iostream>
#include <string>
#include <list>
#include <cstdlib>
#include <algorithm> //find()
#include <sstream>  //ostringstream
#include <iomanip> //setfill() setw();

using namespace std;

const int NUMBER_COUNT = 7;
const int NUMBER_MAX = 36;
const int NUMBER_MIN = 1;
const int ROWS_COUNT = 10;


//*****************************************************************************
//    Function that returns random number between NUMBER_MIN and NUMBER_MAX
//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
int Bold()
{
    return (rand() % (NUMBER_MAX - NUMBER_MIN + 1) + NUMBER_MIN);
}

//*****************************************************************************
// Returns random number between NUMBER_MIN and NUMBER_MAX
// Will always return a different random number until this function is call
// whith new_draw=true.
//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
int Kugle(bool new_draw = false)
{
    static list<int> drawn_lst; //list to keep values that have been draw.
    if (new_draw) // Clean and return.
    {
        drawn_lst.clear(); //New deal, clears the list
    }
    else if (drawn_lst.size() >= (unsigned int)NUMBER_MAX)
	//else if (drawn_lst.size() >= NUMBER_MAX)
    {
        cout << "*** No more balls - clear list ***" << endl;  
    }
    else
    {
        int ball = 0;
        do
        {
            ball = Bold();
        }
        while (drawn_lst.end() != find(drawn_lst.begin(), drawn_lst.end(), ball));
        drawn_lst.push_back(ball);
    }
    return drawn_lst.back();
}


//*****************************************************************************
// Inserts random numbers in the list lst.
// Count of random numbers are NUMBER_COUNT.
//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
void Saturday(list<int> &lst)
{
    for (int i = 0;NUMBER_COUNT > i;i++)
    {
        lst.push_back(Kugle());
    }
}


//*****************************************************************************
// Inserts random numbers in list and then insert list in list of list(row_lst).
// cont of random numbers are NUMBER_COUNT
// cont of list in list are ROWS_COUNT
//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
void Lynlotto(list< list<int> > &row_lst)                                          //void fyrir int
{
    for(int i=0; ROWS_COUNT>i;i++)
    {
        list<int> lst;
        Kugle(true);  //Clears the already drawn list of numbers.
        Saturday(lst); //add random numbers to lst
        row_lst.push_back(lst);
    }
}

//*****************************************************************************
//   converts list of int to string e.g. [2] [23] [8] ... etc.
//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
std::string listToString(list<int> &lst)
{
    std::ostringstream o;
    list<int>::iterator it;
    for ( it = lst.begin() ; it != lst.end(); it++ )
    {
        o << " [" << setw(2) << setfill(' ') << *it << "]";
    }
    return o.str();
}

//*****************************************************************************
//   The main funtion
//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
int main(int c, char **a)
{
    //srand((unsigned)&c);
    list< list<int> > lynlotto_lst;  //This is a list of list of integers
    list<int> saturday_lst;  //this is a list of integers
    int bonus_number;  //to keep the bonus number.

    Saturday(saturday_lst); //add random numbers to lst
    bonus_number = Kugle(); //Draw the bonus number
    Kugle(true); //Clear drawn nubmer list.
    Lynlotto(lynlotto_lst); //add random numbers to lst x 10

    cout << endl << "The lotto numbers are:" << endl << "   " << listToString(saturday_lst) << " bonus[" << Kugle() << "]" << endl;

    int ln_num = 0;
    list< list<int> >::iterator it_lyn_rows;
     cout << "The selected numbers are:" << endl;
     for ( it_lyn_rows = lynlotto_lst.begin() ; it_lyn_rows != lynlotto_lst.end(); it_lyn_rows++ )
    {
        ln_num++;
        cout <<  setw(2) << setfill(' ')<< ln_num << ":" <<listToString(*it_lyn_rows) << endl;
    }



    cout << endl << endl;
    return 0;
}

har i nogen idéa hvorfor det kommer,kan det være den udgave af c++ som jeg har,
(Visual c++ 2005 express edition)

Hilsen
Finns

Problemet er i funktionen Kugle, hvis new_draw bliver sat til true kalder du drawn_lst.clear().
Men til slut i funktionen kalder du så drawn_lst.back(), men det må du ikke da der ikke er nogen back, fordi listen er tom.

Problemet er i funktionen Kugle, hvis new_draw bliver sat til true kalder du drawn_lst.clear().
Men til slut i funktionen kalder du så drawn_lst.back(), men det må du ikke da der ikke er nogen back, fordi listen er tom.

Hej Bertel, kan du forklare det lidt bedre, jeg får stadvigt ud den samme kæmpe fejl.

Mvh
Finnur

Når du kalder Kugle med true, vælter programmet, fordi drawn_lst.back() ikke er lovligt.
Da du ikke bruger returværdien fra funktionen i det tilfælde kan du løse problemet ved at returnere 0 i det tilfælde:

int Kugle(bool new_draw = false)
{
    static list<int> drawn_lst; //list to keep values that have been draw.
    if (new_draw) // Clean and return.
    {
        drawn_lst.clear(); //New deal, clears the list
        return 0;
    }

Jeg tror i øvrigt at de fleste vil sige at funktionen Kugle, med sin lokale "static drawn_lst" er dårlig design.