php - Cannot modify header information FEJL! - Udvikleren.dk

Tags: php

Bruger #13706 @ 05.05.08 16:50

Hey sidder og leger lidt frem og tilbage med en tutorial, men har lidt det problem at den bliver ved med at give mig denne error

Warning: Cannot modify header information - headers already sent by (output started at LINK\\Hejsan\\login.php:9) in LINK\\Hejsan\\login.php on line 27

Warning: Cannot modify header information - headers already sent by (output started at LINK\\Hejsan\\login.php:9) in LINK\\Hejsan\\login.php on line 41

min kode ser sådan her ud

Kode

<?php
ob_start();
include("config.php");
 

if(isset($_SESSION['username']) && isset($_SESSION['password'])) {
       //REDIRECT TO USERS PROFILE...
	   header("Location: loggedind.php");
} //end if logged in
//IF SUBMIT BUTTON PRESSED
if(isset($_POST['submit'])) {

   if(!$_POST['brugernavn']) die("Error: You must enter your username before logging in.");
   if(!$_POST['password']) die("Error: You must enter your password before logging in.");
   
 //set cookie if checked
   if(!empty($_POST['stay_in'])) {  
         $joined =''.$_POST['brugernavn'].'[]'.md5($_POST['password']).'';
         setcookie('login_cookie', $joined, 2147483647, '/', '.http://htxvejle.com/klasser_2007_programmering/2z/Rene_Thyge_Nielsen/Hejsan/register.php');   
    } //end if
//verify user...
$get_user = mysql_query("SELECT * FROM `members` WHERE brugernavn = '".$_POST['brugernavn']."' AND 

bruger_pw = '".md5($_POST['password'])."'");
$q = mysql_fetch_object($get_user);
    if(!$q) die("Login Failure: An error occured, please verify your username and password are correct.");
//set session variables 
$_SESSION['logged_in'] = 1;
$_SESSION['brugernavn'] = $_POST['brugernavn']; 
$_SESSION['password'] = $_POST['password']; 
session_write_close();

header("Location: http://htxvejle.com/klasser_2007_programmering/2z/Rene_Thyge_Nielsen/Hejsan");

} else {
//show login form
?>
<form name="login" method="post" action="<? $_SERVER['PHP_SELF']; ?>">
<table>
<tr>
  <td>Username:<input type="text" id="brugernavn" name="brugernavn"></td>
</tr>
<tr>
  <td>Password:<input type="password" id="password" name="password"></td>
</tr>
<tr>
  <td>Submit: <input type="submit" value="Submit" name="submit" id="submit"></td>
</tr>
<tr>
<td>Remember? <input type="checkbox" name="stay_in[]" checked="yes"></td>
</tr>
</table>
</form>
<?
}//end else
?>

9 svar postet i denne tråd vises herunder
3 indlæg har modtaget i alt 9 karma

Sorter efter stemmer Sorter efter dato

Bruger #10216 @ 05.05.08 17:55

4.283

Har ryddet lidt op og fjernet det du ikke har noget at bruge til. Eksempelvis er session_write_close() overflødig.
Hvis du dræber afviklingen af koden, når du sender brugeren videre til en anden side, sikrer du at der ikke foregår en masse du ikke ved noget om.
Kode afvikles stadig selv om du sender header('location...') med til klienten.

Kode

<?php
	include("config.php");
	
	// Check for "logged in" state.
	if(isset($_SESSION['logged_in']) && isset($_SESSION['username']) && isset($_SESSION['password'])) {
		header("Location: loggedind.php"); // Redirect to profile.
		die(); // Stop execution, no need to do anything else
	} //end if
	
	// Check if submit button is pressed
	if(isset($_POST['submit'])) {

		if(!$_POST['brugernavn']) die("Error: You must enter your username before logging in.");
		if(!$_POST['password']) die("Error: You must enter your password before logging in.");
		
		//set cookie if checked
		if(!empty($_POST['stay_in']) && $_POST['stay_in'] == 'yes') {  
			$joined = $_POST['brugernavn'].'[]'.md5($_POST['password']);
			setcookie('login_cookie', $joined, 2147483647, '/', '.http://htxvejle.com/klasser_2007_programmering/2z/Rene_Thyge_Nielsen/Hejsan/register.php');
		} //end if
		
		//verify user...
		$query = mysql_query("
			SELECT *
			FROM `members`
			WHERE brugernavn = '".$_POST['brugernavn']."'
			AND bruger_pw = '".md5($_POST['password'])."'");
		$result = mysql_fetch_object($query);
		
		if(!$result) die("Login Failure: An error occured, please verify that your username and password are correct.");
		
		//set session variables 
		$_SESSION['logged_in'] = 1;
		$_SESSION['brugernavn'] = $_POST['brugernavn']; 
		$_SESSION['password'] = $_POST['password']; 
		
		header("Location: http://htxvejle.com/klasser_2007_programmering/2z/Rene_Thyge_Nielsen/Hejsan");
		die(); // Stop execution, no need to do anything else
	} //end if
?>
<form name="login" method="post" action="<? $_SERVER['PHP_SELF']; ?>">
	<table>
		<tr>
			<td>Username:<input type="text" id="brugernavn" name="brugernavn"></td>
		</tr>
		<tr>
			<td>Password:<input type="password" id="password" name="password"></td>
		</tr>
		<tr>
			<td>Submit: <input type="submit" value="Submit" name="submit" id="submit"></td>
		</tr>
		<tr>
			<td>Remember? <input type="checkbox" name="stay_in" checked="yes"></td>
		</tr>
	</table>
</form>

Indlæg senest redigeret d. 05.05.2008 18:07 af Bruger #10216

Bruger #4683 @ 05.05.08 22:32

183

Fejlen er at du har html før din header...

Som Gnu sagde, så skal headers sendes før alt output.

Jeg har flyttet det ned til efter php-validering - der er ingen grund til at have det først i filen.

Kode

<?php
	include("config.php");
	
	// Check for "logged in" state.
	if(isset($_SESSION['logged_in']) && isset($_SESSION['username']) && isset($_SESSION['password'])) {
		header("Location: loggedind.php"); // Redirect to profile.
		die(); // Stop execution, no need to do anything else
	} //end if
	
	// Check if submit button is pressed
	if(isset($_POST['submit'])) {

		if(!$_POST['brugernavn']) die("Error: You must enter your username before logging in.");
		if(!$_POST['password']) die("Error: You must enter your password before logging in.");
		
		//set cookie if checked
		if(!empty($_POST['stay_in']) && $_POST['stay_in'] == 'yes') {  
			$joined = $_POST['brugernavn'].'[]'.md5($_POST['password']);
			setcookie('login_cookie', $joined, 2147483647, '/', '.http://htxvejle.com/klasser_2007_programmering/2z/Rene_Thyge_Nielsen/Hejsan/register.php');
		} //end if
		
		//verify user...
		$query = mysql_query("
			SELECT *
			FROM `members`
			WHERE brugernavn = '".$_POST['brugernavn']."'
			AND bruger_pw = '".md5($_POST['password'])."'");
		$result = mysql_fetch_object($query);
		
		if(!$result) die("Login Failure: An error occured, please verify that your username and password are correct.");
		
		//set session variables 
		$_SESSION['logged_in'] = 1;
		$_SESSION['brugernavn'] = $_POST['brugernavn']; 
		$_SESSION['password'] = $_POST['password']; 
		
		header("Location: http://htxvejle.com/klasser_2007_programmering/2z/Rene_Thyge_Nielsen/Hejsan");
		die(); // Stop execution, no need to do anything else
	} //end if
?>
<form name="login" method="post" action="<? $_SERVER['PHP_SELF']; ?>">
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<title>Untitled Document</title>
</head>

<body>
	<table>
		<tr>
			<td>Username:<input type="text" id="brugernavn" name="brugernavn"></td>
		</tr>
		<tr>
			<td>Password:<input type="password" id="password" name="password"></td>
		</tr>
		<tr>
			<td>Submit: <input type="submit" value="Submit" name="submit" id="submit"></td>
		</tr>
		<tr>
			<td>Remember? <input type="checkbox" name="stay_in" checked="yes"></td>
		</tr>
	</table>
</form>

</body>
</html>

Indlæg senest redigeret d. 05.05.2008 22:36 af Bruger #4683

Bruger #8223 @ 06.05.08 11:47

1.065

PHP først, HTML sidst. Altid, hver gang. Husk den regel, og du slipper for alt dette besvær fremover.

Bruger #4683 @ 05.05.08 17:04

183

Kode

<?php
ob_start();
include("config.php");
 

if(isset($_SESSION['username']) && isset($_SESSION['password'])) {
       //REDIRECT TO USERS PROFILE...
	   header("Location: loggedind.php");
} //end if logged in
//IF SUBMIT BUTTON PRESSED
if(isset($_POST['submit'])) {

   if(!$_POST['brugernavn']) die("Error: You must enter your username before logging in.");
   if(!$_POST['password']) die("Error: You must enter your password before logging in.");
   
 //set cookie if checked
   if(!empty($_POST['stay_in'])) {  
         $joined =''.$_POST['brugernavn'].'[]'.md5($_POST['password']).'';
         setcookie('login_cookie', $joined, 2147483647, '/', '.http://htxvejle.com/klasser_2007_programmering/2z/Rene_Thyge_Nielsen/Hejsan/register.php');   
    } //end if
//verify user...
$get_user = mysql_query("SELECT * FROM `members` WHERE brugernavn = '".$_POST['brugernavn']."' AND 

bruger_pw = '".md5($_POST['password'])."'");
$q = mysql_fetch_object($get_user);
    if(!$q) die("Login Failure: An error occured, please verify your username and password are correct.");
//set session variables 
$_SESSION['logged_in'] = 1;
$_SESSION['brugernavn'] = $_POST['brugernavn']; 
$_SESSION['password'] = $_POST['password']; 
session_write_close();

header("Location: http://htxvejle.com/klasser_2007_programmering/2z/Rene_Thyge_Nielsen/Hejsan");

} else {
//show login form
?>
<form name="login" method="post" action="<? $_SERVER['PHP_SELF']; ?>">
<table>
<tr>
  <td>Username:<input type="text" id="brugernavn" name="brugernavn"></td>
</tr>
<tr>
  <td>Password:<input type="password" id="password" name="password"></td>
</tr>
<tr>
  <td>Submit: <input type="submit" value="Submit" name="submit" id="submit"></td>
</tr>
<tr>
<td>Remember? <input type="checkbox" name="stay_in[]" checked="yes"></td>
</tr>
</table>
</form>
<?
}//end else
?>

Mangler du ikke bare en ob_end_flush(); sidst i koden?

Bruger #13706 @ 05.05.08 17:31

hmm har prøvet og sætte den ind i

Kode

<?
}ob_end_flush();
//end else
?>

også ved

Kode

header("Location: http://htxvejle.com/klasser_2007_programmering/2z/Rene_Thyge_Nielsen/Hejsan");
ob_end_flush();
} else {
//show login form
?>

men ingen af delene virker

Bruger #13706 @ 05.05.08 18:16

hey mange tak, har prøvet at sætte det ind og nu giver den samme fejl ang den sidste header igen

Warning: Cannot modify header information - headers already sent by (output started at Z:\\wamp\\www\\htxvejle\\klasser_2007_programmering\\2z\\Rene_Thyge_Nielsen\\Hejsan\\login.php:9) in Z:\\wamp\\www\\htxvejle\\klasser_2007_programmering\\2z\\Rene_Thyge_Nielsen\\Hejsan\\login.php on line 45

Kode

<?php
	include("config.php");
	
	// Check for "logged in" state.
	if(isset($_SESSION['logged_in']) && isset($_SESSION['username']) && isset($_SESSION['password'])) {
		header("Location: loggedind.php"); // Redirect to profile.
		die(); // Stop execution, no need to do anything else
	} //end if
	
	// Check if submit button is pressed
	if(isset($_POST['submit'])) {

		if(!$_POST['brugernavn']) die("Error: You must enter your username before logging in.");
		if(!$_POST['password']) die("Error: You must enter your password before logging in.");
		
		//set cookie if checked
		if(!empty($_POST['stay_in']) && $_POST['stay_in'] == 'yes') {  
			$joined = $_POST['brugernavn'].'[]'.md5($_POST['password']);
			setcookie('login_cookie', $joined, 2147483647, '/', '.http://htxvejle.com/klasser_2007_programmering/2z/Rene_Thyge_Nielsen/Hejsan/register.php');
		} //end if
		
		//verify user...
		$query = mysql_query("
			SELECT *
			FROM `members`
			WHERE brugernavn = '".$_POST['brugernavn']."'
			AND bruger_pw = '".md5($_POST['password'])."'");
		$result = mysql_fetch_object($query);
		
		if(!$result) die("Login Failure: An error occured, please verify that your username and password are correct.");
		
		//set session variables 
		$_SESSION['logged_in'] = 1;
		$_SESSION['brugernavn'] = $_POST['brugernavn']; 
		$_SESSION['password'] = $_POST['password']; 
		
		header("Location: http://htxvejle.com/klasser_2007_programmering/2z/Rene_Thyge_Nielsen/Hejsan");
		die(); // Stop execution, no need to do anything else
	} //end if
?>
<form name="login" method="post" action="<? $_SERVER['PHP_SELF']; ?>">
	<table>
		<tr>
			<td>Username:<input type="text" id="brugernavn" name="brugernavn"></td>
		</tr>
		<tr>
			<td>Password:<input type="password" id="password" name="password"></td>
		</tr>
		<tr>
			<td>Submit: <input type="submit" value="Submit" name="submit" id="submit"></td>
		</tr>
		<tr>
			<td>Remember? <input type="checkbox" name="stay_in" checked="yes"></td>
		</tr>
	</table>
</form>

Bruger #10216 @ 05.05.08 22:07

4.283

Hvis filen kun indeholder den kode som jeg har smidt her, så vil det ikke give nogen fejl. Konklusionen må derfor være at du har noget stående som ikke skal stå der på linje 1-4...

Headers skal skrives før alt andet output til browseren. Same goes for sessions.

Er dette indholdet for filen login.php?

Bruger #13706 @ 05.05.08 22:16

hele indholdet er

Kode

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<title>Untitled Document</title>
</head>

<body>
<?php
	include("config.php");
	
	// Check for "logged in" state.
	if(isset($_SESSION['logged_in']) && isset($_SESSION['username']) && isset($_SESSION['password'])) {
		header("Location: loggedind.php"); // Redirect to profile.
		die(); // Stop execution, no need to do anything else
	} //end if
	
	// Check if submit button is pressed
	if(isset($_POST['submit'])) {

		if(!$_POST['brugernavn']) die("Error: You must enter your username before logging in.");
		if(!$_POST['password']) die("Error: You must enter your password before logging in.");
		
		//set cookie if checked
		if(!empty($_POST['stay_in']) && $_POST['stay_in'] == 'yes') {  
			$joined = $_POST['brugernavn'].'[]'.md5($_POST['password']);
			setcookie('login_cookie', $joined, 2147483647, '/', '.http://htxvejle.com/klasser_2007_programmering/2z/Rene_Thyge_Nielsen/Hejsan/register.php');
		} //end if
		
		//verify user...
		$query = mysql_query("
			SELECT *
			FROM `members`
			WHERE brugernavn = '".$_POST['brugernavn']."'
			AND bruger_pw = '".md5($_POST['password'])."'");
		$result = mysql_fetch_object($query);
		
		if(!$result) die("Login Failure: An error occured, please verify that your username and password are correct.");
		
		//set session variables 
		$_SESSION['logged_in'] = 1;
		$_SESSION['brugernavn'] = $_POST['brugernavn']; 
		$_SESSION['password'] = $_POST['password']; 
		
		header("Location: http://htxvejle.com/klasser_2007_programmering/2z/Rene_Thyge_Nielsen/Hejsan");
		die(); // Stop execution, no need to do anything else
	} //end if
?>
<form name="login" method="post" action="<? $_SERVER['PHP_SELF']; ?>">
	<table>
		<tr>
			<td>Username:<input type="text" id="brugernavn" name="brugernavn"></td>
		</tr>
		<tr>
			<td>Password:<input type="password" id="password" name="password"></td>
		</tr>
		<tr>
			<td>Submit: <input type="submit" value="Submit" name="submit" id="submit"></td>
		</tr>
		<tr>
			<td>Remember? <input type="checkbox" name="stay_in" checked="yes"></td>
		</tr>
	</table>
</form>

</body>
</html>

dette er i config filen

Kode

<?php
$dbhost="localhost";
$dbusername="thyge";
$dbpassword="1433";
$dbname="thyge";

// Angiver de forskellige variabler jeg bruger til at connect med

$connect = mysql_connect($dbhost, $dbusername, $dbpassword);
mysql_select_db($dbname,$connect) or die ("Could not select database");

// Her går jeg ind og laver min "connection" til databasen med variablerne

?>

Bruger #13706 @ 06.05.08 13:20

mange tak, og mange tak til alle der har hjulpet med problemet

Cannot modify header information FEJL!

Karma barometer (30 dage)

Modtaget

Givet

Favorit hos
Forum tråde
Artikler